Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ROUTER_LATE role & supporting fields #632

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Add the ROUTER_LATE role & supporting fields #632

merged 1 commit into from
Dec 22, 2024

Conversation

erayd
Copy link
Contributor

@erayd erayd commented Dec 8, 2024 •
edited
Loading

This PR adds the new ROUTER_INFILL ROUTER_LATE role & supporting fields for the following firmware PR:

meshtastic/firmware#5528

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@erayd erayd mentioned this pull request Dec 8, 2024
Open
@GUVWAF
Copy link
Member

GUVWAF commented Dec 9, 2024

What do others think about this idea and the naming?

@thebentern
Copy link
Contributor

I'm not the biggest fan of the naming, as it requires an explanation to users. How do we express the behavior in its simplest terms?

@erayd
Copy link
Contributor Author

erayd commented Dec 9, 2024 •
edited
Loading

How do we express the behavior in its simplest terms?

ROUTER_LATE perhaps? Infill is what I intend to use this for (i.e. serving smaller pockets of population that are shadowed from our major high sites by annoying terrain), so I named it accordingly, but 'late' is descriptive of the actual behaviour.

@thebentern
Copy link
Contributor

Sounds good to me

@erayd erayd marked this pull request as ready for review December 21, 2024 05:55
@GUVWAF GUVWAF changed the title Add the ROUTER_INFILL role & supporting fields Add the ROUTER_LATE role & supporting fields Dec 21, 2024
@erayd
Add the ROUTER_LATE role & supporting fields
b38adc0 
Will always rebroadcast packets, but will do so after all other modes.
Intended for router nodes that are there to provide additional coverage
in areas not already covered by other routers, or to bridge around
problematic terrain, but should not be given priority over other routers
in order to avoid unnecessarily consuming hops.
@erayd
Copy link
Contributor Author

erayd commented Dec 21, 2024

Have squashed the commits to make it easier to wrangle.

@caveman99 caveman99 merged commit c55f120 into meshtastic:master Dec 22, 2024
2 checks passed
@erayd erayd deleted the router-infill branch December 22, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GUVWAF GUVWAF GUVWAF approved these changes

@fifieldt fifieldt fifieldt approved these changes

@ianmcorvidae ianmcorvidae Awaiting requested review from ianmcorvidae

@garthvh garthvh Awaiting requested review from garthvh

@thebentern thebentern Awaiting requested review from thebentern

@andrekir andrekir Awaiting requested review from andrekir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@erayd @CLAassistant @GUVWAF @thebentern @fifieldt @caveman99